Fix for bulk editting work packages with hierarchy items #17287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
2 times, most recently
from
2655933
to
f004989
Compare
brunopagno
changed the title
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
from
f004989
to
38ef4a7
Compare
Kharonus
approved these changes
Nov 27, 2024
app/helpers/custom_fields_helper.rb
Outdated
| when "hierarchy" | ||
| options = [[I18n.t(:label_no_change_option), ""]] | ||
| service = CustomFields::Hierarchy::HierarchicalItemService.new | ||
| options += service.get_descendants(item: custom_field.hierarchy_root, include_self: false).value!.map do |item| |
There was a problem hiding this comment.
🟡 This goes into a direction, we had already on some other places:
is .value! enough for the failure handling? it means: "Throw on failure". So, while the method currently cannot return a failure, this might change in future, the interface is a Result.
Should we have small .either handling here? Maybe raising (as it is now) or returning empty options together with an error log entry?
There was a problem hiding this comment.
I meant to do that when I refactored, but forgot. Adjusted it now.
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
from
38ef4a7
to
f9c9780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
The link to the ticket number 59734
What are you trying to accomplish?
Fix bulk edit for work packages that have custom fields with format hierarchy